- 16 Jan, 2020 1 commit
-
-
Shu Fujita authored
-
- 15 Jan, 2020 3 commits
-
-
Shu Fujita authored
I refactored `AnnotateRoutes.header` for performance, and add `AnnotateRoutes.comment` to make code DRY.
-
Shu Fujita authored
As the change log shows, I froze the constant `HEADER_ROW` in accordance with the normal Ruby style regulation.
-
Shu Fujita authored
I added `AnnotateModels::MAGIC_COMMENT_MATCHER` and `AnnotateRoutes::MAGIC_COMMENT_MATCHER` instad of `AnnotateModels.magic_comment_matcher` and `AnnotateRoutes.magic_comment_matcher`. I think that they should be constants because the result of Regexp is always fixed.
-
- 06 Jan, 2020 1 commit
-
-
Shu Fujita authored
Before I commited, the method `AnnotateRoutes.where_header_found` returned an array of `real_content` and `header_found_at`. I fixed the name of method and variable because they did not match. I renamed the method `real_content_and_header_position` and unified related variable names to `header_position`.
-
- 30 Dec, 2019 1 commit
-
-
Andrew W. Lee authored
This change converts .all_options into a constant and moves it into Annotate::Constants. It also changes usages of .all_options.
-
- 18 Dec, 2019 3 commits
-
-
naari3 authored
Replace soft-deprecated constant `HashWithIndifferentAccess` to `ActiveSupport::HashWithIndifferentAccess` (#699)
-
Alexander Belozerov authored
-
inkstak authored
Same problem returned by @janosrusiczki in #430 Spatial columns with activerecord-postgis-adapter (5.2.2) are not displayed nice ``` # name :string(3) # active :boolean default(FALSE), not null # geom :geometry({:srid= geometry, 4326 ``` That's come from activerecord-postgis-adapter, with redefined columns as such : ``` #<ActiveRecord::ConnectionAdapters::PostGIS::SpatialColumn @sql_type="geometry(Geometry,4326)", @geo_type="Geometry", @geometric_type=RGeo::Feature::Geometry, @srid=4326, @limit={:srid=>4326, :type=>"geometry"} [...] > ``` This fix displays them like this : ``` # name :string(3) # active :boolean default(FALSE), not null # geometry :geometry geometry, 4326 ``` Another possibility would have been to display them as below, but it involves a lot of extra-spaces for other columns. ``` # name :string(3) # active :boolean default(FALSE), not null # geometry :geometry(Geometry, 4326) ```
-
- 02 Dec, 2019 2 commits
-
-
Daniel Rice authored
ActiveAdmin defaults to false. Add `active_admin` option so people using this gem can more easily enable annotating files in `app/admin`.
-
Hrvoje Šimić authored
Rails 6 has dropped name from ActiveRecord::ConnectionAdapters::ForeignKeyDefinition for Sqlite3 adapter: https://github.com/rails/rails/blob/f2df77709f7e536aaf4d6f984ff21a49d44d34c1/activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb\#L305-L311 This has caused issues with getting foreign key info and blowing up when trying to annotate models with foreign keys. This commit adds one additional check for name presence and uses column attribute from options instead. Closes #620.
-
- 09 Nov, 2019 6 commits
-
-
Matías Orellana authored
-
Alexander Belozerov authored
-
Alexander Belozerov authored
-
Kyle Zhao authored
-
hasimoto1009 authored
-
Andrew W. Lee authored
-
- 31 Oct, 2019 1 commit
-
-
rhiroshi authored
Setting the default to annotate models as it is the main feature of the gem
-
- 29 Sep, 2019 1 commit
-
-
Andrew W. Lee authored
-
- 28 Sep, 2019 1 commit
-
-
Andrew W. Lee authored
Changed references to `--additional_file_patterns` to be `--additional-file-patterns` to make it consistent with other flags.
-
- 26 Sep, 2019 1 commit
-
-
Andrew W. Lee authored
Adds tests for `.include_routes?`, `.include_models?`, `.skip_on_migration?`. Also moves the `TRUE_RE` under the `Annotate::Constants` namespace.
-
- 16 Sep, 2019 1 commit
-
-
rnitta authored
-
- 03 Sep, 2019 2 commits
-
-
Andrew W. Lee authored
-
Andrew W. Lee authored
Prior to this change, `Annotate.include_models?` returned the inverse of `Annotate.include_routes?`. This made it so annotating models and routes was not possible to do together. This PR adds an explicit `--models` flag and also adds it the option to `lib/generators/annotate/templates/auto_annotate_models.rake` with the default being set to `false`. Fixes #563 and undoes the bug introduced in #485.
-
- 02 Sep, 2019 1 commit
-
-
Prateek Choudhary authored
-
- 08 Aug, 2019 1 commit
-
-
Ryan authored
Add better documentation for new option for additional file patterns. Implemented in #633 and #636.
-
- 06 Aug, 2019 1 commit
-
-
Ryan authored
Adds option for additional file patterns (implemented in #633) in the CLI.
-
- 16 Jul, 2019 1 commit
-
-
Andrew W. Lee authored
Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
-
- 10 Jul, 2019 1 commit
-
-
Ryan authored
This PR adds an option named `additional_file_patterns`. You can specify custom path patterns (including globs) that the gem will use to annotate. For example, I used it like this on a project: ```ruby Annotate.set_defaults( 'additional_file_patterns' => [ File.join(Rails.application.root, 'app/lib/forms/%PLURALIZED_MODEL_NAME%/**/*.rb'), File.join(Rails.application.root, 'spec/lib/forms/%PLURALIZED_MODEL_NAME%/**/*.rb') ], ... ) ``` This makes it possible to have files nested under a directory which corresponds to the model. I believe this fixes #594.
-
- 07 Jul, 2019 1 commit
-
-
Andrew W. Lee authored
Currently there's no test coverage on CLI. This adds tests for a new class Parser which will replace the command line options currently in bin/annotate. The technical direction I'm planning to go is to remove ENV variables completely and to have things passed into as arguments. Will be adding deprecation warnings in 3.0 and then deprecate ENV variables completely in 3.1. Deprecation warnings will be non-blocking in 3.0 when an ENV variable is set and an argument isn't passed in, and will becoming blocking in 3.1.
-
- 23 May, 2019 1 commit
-
-
Colby Melvin authored
Handle potential negative padding in `#mb_chars_ljust` when having a `col_length` > 16, the default hardcoded value of `bare_type_allowance`.
-
- 28 Apr, 2019 1 commit
-
-
Shu Fujita authored
In AnnotateRoutes, there were many public methods that is not used in other classes or modules. Before my extension, I made these methods private and sort them in order of appearance. All tests were passed. Please trace each commits carefully. I didn't nothing special. The commits consist of coordinating code.
-
- 22 Apr, 2019 1 commit
-
-
Andrew W. Lee authored
-
- 08 Apr, 2019 1 commit
-
-
Daisuke Yokomoto authored
Add --frozen option to abort instead of write annotation. This is mainly for CI environment to detect missing annotation. Similar motivation with bundle install --frozen. works like: ``` $ rake db:migrate frozen=yes annotate error. spec/models/user_spec.rb needs to be updated, but annotate was run with `--frozen ```
-
- 15 Feb, 2019 2 commits
-
-
Ben Brook authored
-
Artem Rashev authored
Since Rails full engines run as non-namespaced applications but all their app-related tasks still prefixed with `app:`
-
- 14 Feb, 2019 1 commit
-
-
Yuichi Tanikawa authored
- Use Rake::Task#enhance insteaad of defining same tasks again - Remove hooking db:migrate:change task which doesn't exist - Fix hooking db:migrate:reset task so that the annotation runs after all migration tasks (#548)
-
- 22 Jan, 2019 1 commit
-
-
Tim Perkins authored
-
- 09 Sep, 2018 1 commit
-
-
oieioi authored
This fixes alignment of Japanese, Korean and Chinese fullwidth character comments. The displayed widths of multi-byte fullwidth characters are generally twice as large as the ASCII characters, but String#size returns only the number of characters. So if the column comment contains fullwidth multibyte characters, the alignment is broken.
-
- 06 Sep, 2018 1 commit
-
-
Jeremy Mickelson authored
* refactor and simplify returns for annotate_one_file * fix rubocop offenses
-