1. 16 Jan, 2020 1 commit
  2. 15 Jan, 2020 3 commits
  3. 06 Jan, 2020 1 commit
    • Rename method and variable of AnnotateRoutes for readability (#709) · ee88f0fd
      Shu Fujita authored
      Before I commited, the method `AnnotateRoutes.where_header_found` returned an array of `real_content` and `header_found_at`.
      
      I fixed the name of method and variable because they did not match.
      
      I renamed the method `real_content_and_header_position` and unified related variable names to `header_position`.
  4. 30 Dec, 2019 1 commit
    • Refactor lib/annotate.rb (#707) · 3f0b6b32
      Andrew W. Lee authored
      This change converts .all_options into a constant and moves it into Annotate::Constants. It also changes usages of .all_options.
  5. 18 Dec, 2019 3 commits
    • Replace soft-deprecated constant `HashWithIndifferentAccess` to… · a05e4586
      naari3 authored
      Replace soft-deprecated constant `HashWithIndifferentAccess` to `ActiveSupport::HashWithIndifferentAccess` (#699)
      
    • [Fix #430] Handle columns from activerecord-postgis-adapter (#694) · c13fe49c
      inkstak authored
      Same problem returned by @janosrusiczki in #430
      
      Spatial columns with activerecord-postgis-adapter (5.2.2) are not displayed nice
      
      ```
      # name           :string(3)
      # active         :boolean          default(FALSE), not null
      # geom           :geometry({:srid= geometry, 4326
      ```
      
      That's come from activerecord-postgis-adapter, with redefined columns as such :
      
      ``` 
      #<ActiveRecord::ConnectionAdapters::PostGIS::SpatialColumn 
        @sql_type="geometry(Geometry,4326)",
        @geo_type="Geometry",
        @geometric_type=RGeo::Feature::Geometry,
        @srid=4326,
        @limit={:srid=>4326, :type=>"geometry"}
        [...]
      >
      ```
      
      This fix displays them like this :
      
      ```
      # name           :string(3)
      # active         :boolean          default(FALSE), not null
      # geometry       :geometry         geometry, 4326
      ```
      
      Another possibility would have been to display them as below, but it involves a lot of extra-spaces for other columns.
      
      ```
      # name           :string(3)
      # active         :boolean                   default(FALSE), not null
      # geometry       :geometry(Geometry, 4326)
      ```
  6. 02 Dec, 2019 2 commits
  7. 09 Nov, 2019 6 commits
  8. 31 Oct, 2019 1 commit
  9. 29 Sep, 2019 1 commit
  10. 28 Sep, 2019 1 commit
  11. 26 Sep, 2019 1 commit
  12. 16 Sep, 2019 1 commit
  13. 03 Sep, 2019 2 commits
    • v3.0.0 · 0ad3424e
      Andrew W. Lee authored
    • Make it possible to annotate models and routes together (#647) · 846c7f8e
      Andrew W. Lee authored
      Prior to this change, `Annotate.include_models?` returned the inverse of `Annotate.include_routes?`. This made it so annotating models and routes was not possible to do together.
      
      This PR adds an explicit `--models` flag and also adds it the option to `lib/generators/annotate/templates/auto_annotate_models.rake` with the default being set to `false`. 
      
      Fixes #563 and undoes the bug introduced in #485.
  14. 02 Sep, 2019 1 commit
  15. 08 Aug, 2019 1 commit
  16. 06 Aug, 2019 1 commit
  17. 16 Jul, 2019 1 commit
    • Refactor Parser (#641) · f8f1b178
      Andrew W. Lee authored
      Refactored Parser to isolate changes being made to ENV. This way we have an intermediate step where we know the environment variables being set.
  18. 10 Jul, 2019 1 commit
    • Add option for additional file patterns (#633) · f95913ba
      Ryan authored
      This PR adds an option named `additional_file_patterns`.  You can specify custom path patterns (including globs) that the gem will use to annotate.
      
      For example, I used it like this on a project:
      
      ```ruby
      Annotate.set_defaults(
            'additional_file_patterns' => [
              File.join(Rails.application.root, 'app/lib/forms/%PLURALIZED_MODEL_NAME%/**/*.rb'),
              File.join(Rails.application.root, 'spec/lib/forms/%PLURALIZED_MODEL_NAME%/**/*.rb')
            ],
            ...
      )
      ```
      
      This makes it possible to have files nested under a directory which corresponds to the model.
      
      I believe this fixes #594.
  19. 07 Jul, 2019 1 commit
    • Add tests for the CLI (#635) · f612f8ad
      Andrew W. Lee authored
      Currently there's no test coverage on CLI. This adds tests for a new class Parser which will replace the command line options currently in bin/annotate.
      
      The technical direction I'm planning to go is to remove ENV variables completely and to have things passed into as arguments. Will be adding deprecation warnings in 3.0 and then deprecate ENV variables completely in 3.1. Deprecation warnings will be non-blocking in 3.0 when an ENV variable is set and an argument isn't passed in, and will becoming blocking in 3.1.
  20. 23 May, 2019 1 commit
  21. 28 Apr, 2019 1 commit
    • Make methods private in AnnotateRoutes (#598) · 289621b8
      Shu Fujita authored
      In AnnotateRoutes, there were many public methods that is not used in other classes or modules.
      
      Before my extension, I made these methods private and sort them in order of appearance.
      
      All tests were passed.
      
      Please trace each commits carefully. I didn't nothing special. The commits consist of coordinating code.
  22. 22 Apr, 2019 1 commit
  23. 08 Apr, 2019 1 commit
    • Add frozen option for CI environment (#603) · fe172282
      Daisuke Yokomoto authored
      Add --frozen option to abort instead of write annotation.
      This is mainly for CI environment to detect missing annotation.
      Similar motivation with bundle install --frozen.
      
      works like:
      ```
      $ rake db:migrate frozen=yes
      
      annotate error. spec/models/user_spec.rb needs to be updated, but annotate was run with `--frozen
      ```
  24. 15 Feb, 2019 2 commits
  25. 14 Feb, 2019 1 commit
    • Refactor hooking ActiveRecord migration tasks (#588) · dc827279
      Yuichi Tanikawa authored
      - Use Rake::Task#enhance insteaad of defining same tasks again
      - Remove hooking db:migrate:change task which doesn't exist
      - Fix hooking db:migrate:reset task so that the annotation runs after
        all migration tasks (#548)
  26. 22 Jan, 2019 1 commit
  27. 09 Sep, 2018 1 commit
    • Fix alignment of multi-byte fullwidth character comments (#575) · 26142667
      oieioi authored
      This fixes alignment of Japanese, Korean and Chinese fullwidth character comments.
      
      The displayed widths of multi-byte fullwidth characters are generally
      twice as large as the ASCII characters, but String#size returns only the number of characters.
      So if the column comment contains fullwidth multibyte characters, the alignment is broken.
  28. 06 Sep, 2018 1 commit