增加 import 测试

Gemfile.lock

@@ -2,7 +2,7 @@ PATH
   remote: .
   specs:
     tallty_import_export (0.1.0)
-      activesupport (~> 6.0.3)
+      activesupport
       caxlsx
       roo
       roo-xls

lib/tallty_import_export.rb

@@ -8,7 +8,10 @@ module TalltyImportExport
 
   autoload :Common
   autoload :Exportable
+  autoload :Export
   autoload :Importable
+  autoload :Import
+  autoload :Context
 
   class Error < StandardError; end
 end

lib/tallty_import_export/exportable.rb

@@ -3,7 +3,7 @@ module TalltyImportExport
     extend ActiveSupport::Concern
 
     included do |base|
-      base.include(Common)
+      # base.include(Common)
       base.const_set('Export', Class.new(TalltyImportExport::Export))
     end
 

lib/tallty_import_export/import.rb

-class Import
-  attr_reader :klass, :content, :headers, :primary_keys
+module TalltyImportExport
+  class Import
+    require 'roo'
+    attr_reader :klass, :context, :headers, :primary_keys
 
-  def initialize klass
-    @klass = klass
-    @content = Context.new({})
-  end
+    def initialize klass
+      @klass = klass
+      @context = Context.new({})
+    end
+
+    # key: 属性的英文名
+    # name: 属性的中文名
+    # attr_type: 属性的类型
+    # format: excel是否需要特定的格式，目前主要是类似于身份证号，可以用string
+    # convert: 导入时候，把excel的内容转换成导入时候代码逻辑需要的内容
+    # primary_key: 是否是主键
 
-  # key: 属性的英文名
-  # name: 属性的中文名
-  # attr_type: 属性的类型
-  # format: excel是否需要特定的格式，目前主要是类似于身份证号，可以用string
-  # convert: 导入时候，把excel的内容转换成导入时候代码逻辑需要的内容
-  # primary_key: 是否是主键
+    def import_xlsx xlsx_file, associations, options={}
+      # 先处理获取出来Excel每行的数据, line_info
+      options = options.with_indifferent_access
 
-  def import_xlsx xlsx_file, associations, options={}
-    # 先处理获取出来Excel每行的数据, line_info
-    options = options.with_indifferent_access
+      self.headers = options.delete(:headers) || import_headers
+      @primary_keys = options.delete(:primary_keys) || headers.map { |header| header[:primary_key] ? header[:key].to_sym : nil }.compact
+
+      excel_hash = headers.reduce({}) do |h, header|
+        h[header[:key]] = header[:name]
+        h
+      end
+      file_path = xlsx_file.is_a?(String) ? xlsx_file : xlsx_file.path
+      xlsx = ::Roo::Excelx.new(file_path)
+      xlsx.each_with_pagename do |_sheetname, sheet|
+        sheet.each(**excel_hash).with_index do |line_info, index|
+          next if index == 0
 
-    self.headers = options.delete(:headers) || import_headers
-    self.primary_keys = options.delete(:primary_keys) || headers.map { |header| header[:primary_key] ? header[:key].to_sym : nil }.compact
+          # 转换处理导入的数据格式
+          line_info = convert_data(line_info)
 
-    excel_hash = headers.reduce({}) do |h, header|
-      h[header[:key]] = header[:name]
-      h
+          # 处理每行对于导入的动作,处理line_info
+          import_record(line_info, associations)
+          context.last_line_info = line_info
+        end
+      end
     end
 
-    file_path = xlsx_file.is_a?(String) ? xlsx_file : xlsx_file.path
-    xlsx = Roo::Excelx.new(file_path)
-    xlsx.each_with_pagename do |_sheetname, sheet|
-      sheet.each(**excel_hash).with_index do |line_info, index|
-        next if index == 0
+    def convert_data line_info
+      line_info.with_indifferent_access.reduce({}) do |h, (k, v)|
+        header = headers.find do |_header|
+          _header[:key].to_sym == k.to_sym
+        end
+        # header[:convert] = handle_xxx
+        # handle_xxx(val, processing_line_info, raw_line_info)
+        val = header[:convert] ? send(header[:convert], v, h, line_info) : v
+        if header[:json]
+          h[header[:json]] ||= {}
+          h[header[:json]][k] = val
+        else
+          h[k.to_sym] = val
+        end
+        h
+      end.with_indifferent_access
+    end
 
-        # 转换处理导入的数据格式
-        line_info = convert_data(line_info)
+    def import_headers
+      klass.try(:headers) || klass.try(:model_headers)
+    end
 
-        # 处理每行对于导入的动作,处理line_info
-        import_record(line_info, associations)
-      end
+    def headers= val
+      @headers = val.map { |header| header.with_indifferent_access }
     end
-  end
 
-  def convert_data line_info
-    line_info.with_indifferent_access.reduce({}) do |h, (k, v)|
-      header = headers.find do |_header|
-        _header[:key].to_sym == k.to_sym
-      end
-      val = header[:convert] ? send(header[:convert], v) : v
-      if header[:json]
-        h[header[:json]] ||= {}
-        h[header[:json]][k] = val
+    def skip val, processing_line_info, raw_line_info
+      # do nothing there, use for header[:convert]
+    end
+
+    ###  这个方法是可以由复杂业务进行重载的 ###
+    def import_record line_info, associations
+      if primary_keys.present?
+        _record = associations.find_or_initialize_by(line_info.clone.extract!(*primary_keys))
+        _record.update!(line_info.clone.except!(*primary_keys))
       else
-        h[k.to_sym] = val
+        associations.create!(line_info)
       end
-      h
-    end.with_indifferent_access
-  end
-
-  def import_headers
-    klass.try(:headers) || kless.try(:model_headers)
-  end
 
-  ###  这个方法是可以由复杂业务进行重载的 ###
-  def import_record line_info, associations
-    if primary_keys.present?
-      _record = associations.find_or_initialize_by(line_info.clone.extract!(*primary_keys))
-      _record.update!(line_info.clone.except!(*primary_keys))
-    else
-      associations.create!(line_info)
     end
-
   end
 end

lib/tallty_import_export/importable.rb

@@ -3,13 +3,13 @@ module TalltyImportExport
     extend ActiveSupport::Concern
 
     included do |base|
-      base.include(Common)
+      # base.include(Common)
       base.const_set('Import', Class.new(TalltyImportExport::Import))
     end
 
     module ClassMethods
       def import_instance
-        Import.new(self)
+        const_get('Import').new(self)
       end
 
       def import_xlsx *args

spec/importable_spec.rb

+RSpec.describe TalltyImportExport::Importable do
+  before do
+    class Test
+      include TalltyImportExport::Importable
+
+      class << self
+        def model_headers
+          [
+            { key: 'name', name: '名称' },
+            { key: 'code', name: '学号', convert: :handle_code },
+            { key: 'sub_code', name: '副学号', convert: :skip},
+            { key: 'meta1', name: 'meta字段1', json: :meta },
+            { key: 'meta2', name: 'meta字段2', json: :meta },
+          ]
+        end
+      end
+
+      class Import
+        def import_record line_info, associations
+          associations << line_info
+        end
+
+        def handle_code code, processing_line_info, raw_line_info
+          "#{code}_#{raw_line_info['sub_code']}"
+        end
+      end
+    end
+  end
+
+  it "has a version number" do
+    # 名称	学号	  副学号	meta字段1	meta字段2
+    # 1	  20070101	1	    meta1	    metaA
+    # 2	  20070102	2	    meta2	    metaB
+    # 3	  20070103	3	    meta3	    metaC
+    # 4	  20070104	4	    meta4	    metaD
+    # 5	  20070105	5	    meta5	    metaE
+    @result = []
+    Test.import_xlsx('./spec/test1.xlsx', @result)
+
+    expect(@result).to eq([
+      {"name"=>1, "code"=>"20070101_1", "sub_code"=>nil, "meta"=>{"meta1"=>"meta1", "meta2"=>"metaA"}},
+      {"name"=>2, "code"=>"20070102_2", "sub_code"=>nil, "meta"=>{"meta1"=>"meta2", "meta2"=>"metaB"}},
+      {"name"=>3, "code"=>"20070103_3", "sub_code"=>nil, "meta"=>{"meta1"=>"meta3", "meta2"=>"metaC"}},
+      {"name"=>4, "code"=>"20070104_4", "sub_code"=>nil, "meta"=>{"meta1"=>"meta4", "meta2"=>"metaD"}},
+      {"name"=>5, "code"=>"20070105_5", "sub_code"=>nil, "meta"=>{"meta1"=>"meta5", "meta2"=>"metaE"}},
+    ])
+  end
+end

spec/tallty_import_export_spec.rb

@@ -2,8 +2,4 @@ RSpec.describe TalltyImportExport do
   it "has a version number" do
     expect(TalltyImportExport::VERSION).not_to be nil
   end
-
-  it "does something useful" do
-    expect(false).to eq(true)
-  end
 end